Skip to content

CI: Add formatting validation steps #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2025
Merged

CI: Add formatting validation steps #42

merged 1 commit into from
Nov 19, 2025
+654 −594

Conversation

@jserv
Copy link
Contributor

@jserv jserv commented Nov 19, 2025 •
edited by cubic-dev-ai bot
Loading

The following scripts are added to GitHub Actions workflow:

  • check-format.sh to validate C/C++ and shell script formatting
  • check-newline.sh to ensure files end with newline

Close #33

Summary by cubic

Adds formatting and newline checks to CI to enforce a consistent code style and fail fast on mismatches. Also reformats CI shell scripts for consistent style; no logic changes.

  • New Features

    • Added .ci/check-format.sh (clang-format-18 for C/C++, shfmt for shell).
    • Added .ci/check-newline.sh to ensure tracked text files end with a newline (skips binaries).
    • Integrated both checks into .github/workflows/ci.yml.
    • Added .editorconfig to standardize shell script formatting.

  • Dependencies

    • Installs clang-format-18 and shfmt in CI.

Written for commit d57e45a. Summary will update automatically on new commits.

@jserv
CI: Add formatting validation steps
d57e45a 
The following scripts are added to GitHub Actions workflow:
- check-format.sh to validate C/C++ and shell script formatting
- check-newline.sh to ensure files end with newline

Close #33
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

Linmo CI Test Results

Overall Status: ✅ passed
Timestamp: 2025-11-19T19:06:54+00:00

Toolchain Results

Toolchain Build Crash Test Functional
GNU ✅ passed ✅ passed ✅ passed
LLVM ✅ passed ⏭️ skipped ⏭️ skipped

Application Tests

App GNU LLVM
cond ✅ passed ⏭️ skipped
coop ✅ passed ⏭️ skipped
cpubench ✅ passed ⏭️ skipped
echo ✅ passed ⏭️ skipped
hello ✅ passed ⏭️ skipped
mqueues ✅ passed ⏭️ skipped
mutex ✅ passed ⏭️ skipped
pipes ✅ passed ⏭️ skipped
pipes_small ✅ passed ⏭️ skipped
pipes_struct ✅ passed ⏭️ skipped
prodcons ✅ passed ⏭️ skipped
progress ✅ passed ⏭️ skipped
rtsched ✅ passed ⏭️ skipped
semaphore ✅ passed ⏭️ skipped
suspend ✅ passed ⏭️ skipped
test64 ✅ passed ⏭️ skipped
test_libc ✅ passed ⏭️ skipped
timer ✅ passed ⏭️ skipped
timer_kill ✅ passed ⏭️ skipped

Functional Test Details

Test GNU LLVM
mutex:data_consistency ✅ passed ⏭️ skipped
mutex:fairness ✅ passed ⏭️ skipped
mutex:mutual_exclusion ✅ passed ⏭️ skipped
mutex:overall ✅ passed ⏭️ skipped
semaphore:all_tests_passed! ✅ passed ⏭️ skipped

Report generated from test-summary.toml

cubic-dev-ai[bot]
cubic-dev-ai bot reviewed Nov 19, 2025
View reviewed changes
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 8 files

@jserv jserv merged commit d7d1fe1 into main Nov 19, 2025
4 checks passed
@jserv jserv deleted the ci-format branch November 19, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CI: Automate formatting checks for C, Shell, and Python

2 participants

@jserv